Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event modifications #61

Merged
merged 4 commits into from
Jan 21, 2019
Merged

Event modifications #61

merged 4 commits into from
Jan 21, 2019

Conversation

brianpkelley
Copy link
Contributor

@brianpkelley brianpkelley commented Jan 16, 2019

Added "stepopen", "stepclose", and moved "stepchange", as well as updated the docs and added new "Events" Demo section
Fixes #60

@Kinark
Copy link
Owner

Kinark commented Jan 19, 2019

Hey, @brianpkelley!
Thanks you for the PR :)

But could you please move the changes made in src/html_docs/components/scripts.html file to src/html_docs/components/sections/components/api/components/events.html file?

I mean, just like I did in here. I'm trying to keep everything modularized :)

@Kinark
Copy link
Owner

Kinark commented Jan 21, 2019

Just fixed what I needed to fix.
Thanks for the PR! :D

I'm merging it right now and releasing a version real soon.

@Kinark Kinark merged commit 56528b7 into Kinark:develop Jan 21, 2019
@Kinark
Copy link
Owner

Kinark commented Jan 21, 2019

#60 Fixed

@Kinark Kinark mentioned this pull request Jan 21, 2019
@brianpkelley
Copy link
Contributor Author

Ah sorry, my family and I are right in the middle of a move, glad I could help out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants