Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build action failed #8

Closed
thinium opened this issue Sep 16, 2022 · 6 comments
Closed

Build action failed #8

thinium opened this issue Sep 16, 2022 · 6 comments

Comments

@thinium
Copy link

thinium commented Sep 16, 2022

Hi! I just tried to build the ZMK firmware for the first time. But the action failed in two places. Is it possible there is an issue in the build script? How can I fix them?

Here is my build action: https://github.com/thinium/Adv360-Pro-ZMK/actions/runs/3061013510/jobs/4940248396#step:8:37

Screenshot 2022-09-16 at 09 18 20
Screenshot 2022-09-16 at 09 18 30

@thinium
Copy link
Author

thinium commented Sep 16, 2022

fixed.... it's caused by an empty biding

@KinesisCorporation
Copy link
Owner

Great!

@dustMason
Copy link

i'm having the same error - can you describe how you fixed it? i changed only a single key binding but am seeing this error on my github actions build

@thinium
Copy link
Author

thinium commented Sep 18, 2022

@dustMason in my case there is a macro that is empty (it contains no keys). After removing that macro everything works fine. Yours seems to be a different issue from mine. @KinesisCorporation it would be great to publish a list of typical mistakes and how to fix them. Also for newbies to build action how to debug it. The ZMK people told me that your version has diverged a lot from theirs (it seems that yours is based on a rather old version), and they might not be able to provide much help in the future.

@dustMason
Copy link

Thank you – it turns out that my error was also caused by an empty macro. I rolled back my changes one by one until i discovered the empty macro. It's easy to make this mistake in the GUI editor – I suggest adding a validation in the editor to prevent saving an empty macro.

@KinesisCorporation
Copy link
Owner

Appreciate all the dialogue guys!

  1. We're about to publish an update that merges our custom features with the latest from ZMK.
  2. And we're starting a troubleshooting tip with a list of common mistakes here:
    https://kinesis-ergo.com/support/kb360pro/#troubleshooting

jonatan-branting pushed a commit to jonatan-branting/Adv360-Pro-ZMK that referenced this issue Feb 1, 2024
# This is the 1st commit message:

Updated keymap
# The commit message KinesisCorporation#2 will be skipped:

# Updated keymap

# The commit message KinesisCorporation#3 will be skipped:

# feat: Add basic changes to make me feel more at home

# The commit message KinesisCorporation#4 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#5 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#6 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#7 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#8 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#9 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#10 will be skipped:

# Reduce brightness of leds

# The commit message KinesisCorporation#11 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#12 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#13 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#14 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#15 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#16 will be skipped:

# Updated adv360.keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants