Show how to use the FxABearerTokenAuth auth. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasserc
reviewed
Feb 13, 2017
README.rst
Outdated
| client_id="<FXA-CLIENT-ID>", | ||
| account_server_url='https://api.accounts.firefox.com/v1', | ||
| oauth_server_url='https://oauth.accounts.firefox.com/v1', | ||
| ) | ||
| client = Client(bucket="payments", collection="receipts", auth=auth) |
There was a problem hiding this comment.
Shouldn't this be a separate example, rather than trying to wedge this in with the example where you can pass bucket and collection to the Client constructor?
There was a problem hiding this comment.
I asked myself the question, but auth wasn't defined and we are talking about FxA just before reason why I added it there. I can change that if you find it confusing.
There was a problem hiding this comment.
Indeed, I would prefer to define auth = ("user", "pass") and explicit FxA in a separate section
leplatrem
reviewed
Feb 14, 2017
README.rst
Outdated
| @@ -79,6 +79,14 @@ at creation time, so that this value will be used by default. | |||
|
|
|||
| .. code-block:: python | |||
|
|
|||
| from fxa.plugins.requests import FxABearerTokenAuth | |||
| auth = FxABearerTokenAuth( | |||
README.rst
Outdated
| client_id="<FXA-CLIENT-ID>", | ||
| account_server_url='https://api.accounts.firefox.com/v1', | ||
| oauth_server_url='https://oauth.accounts.firefox.com/v1', | ||
| ) | ||
| client = Client(bucket="payments", collection="receipts", auth=auth) |
There was a problem hiding this comment.
Indeed, I would prefer to define auth = ("user", "pass") and explicit FxA in a separate section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.