Generate AsyncClient from Client #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
requested review from
leplatrem and
matt-boris
and removed request for
matt-boris
leplatrem
reviewed
Apr 5, 2023
| def async_client(cls): | ||
| for name, method in inspect.getmembers(cls, inspect.isfunction): | ||
| if not (name.startswith("_") or name == "clone"): | ||
| setattr(cls, name, async_wrap(method)) |
grahamalama
force-pushed
the
generate-async-client
branch
from
98d81a4 to
dd7613b
Compare
grahamalama
changed the title
|
Might wait for #308 before fixing the linting on this |
leplatrem
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
I like to see these many duplicated lines removed 🤩
As long as we don't foresee the public API of this client changing soon and constrain ourselves to only using private methods in public methods, we can merge this.
The public API hasn't changed for a long time, and the constraint to use only private methods in public ones is not too bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts the pattern we were using before of wrapping most
Clientmethods in aloop.run_in_executorinto some metaprogramming.I wouldn't exactly call this approach sustainable. We'll run into issues any time we reuse a public method inside another public method, since we won't
awaitthe call in theClientbut will need to in theAsyncClient. This happened to me in this PR with_create_if_not_existsand_delete_if_exists.As long as we don't foresee the public API of this client changing soon and constrain ourselves to only using private methods in public methods, we can merge this. Or, we can redouble our efforts to make the Async client truly async-compatible from the ground up, since I'm not sure just wrapping the
Clientmethods inloop.run_in_executor(None, func)cuts it.