Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize repo #365

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Modernize repo #365

merged 10 commits into from
Jan 29, 2024

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Jan 26, 2024 •
edited
Loading

  • Replaced setup.cfg and setup.py by pyproject.toml
  • Replaced flake8 by ruff
  • Use requirements.in instead of list in setup.py
  • Replaced manually created requirements.txt by pip-compile
  • Remove dev-requirements.txt file and use extra dependencies instead
  • Use version from git tag (setuptools-scm)
  • Publish to Pypi on git tag
  • Add config to categorize changes in autogenerated changelog
  • Add Github actions to dependabot
  • Update release instructions
  • Rename master to main
  • Replace tox with GH actions
  • Move tests out of package
  • Move package to src
  • Force labels on pull-requests (for better changelog)

Things lost with this PR:

  • No more changelog (now on GH releases)
  • Description on Pypi does not contain changelog anymore

@leplatrem leplatrem marked this pull request as ready for review January 26, 2024 10:39
@leplatrem
Copy link
Contributor Author

Why unit tests have 100% but coveralls reports 98%? 🤔 https://coveralls.io/jobs/135253050

@leplatrem leplatrem requested a review from alexcottner January 26, 2024 10:55
@alexcottner
Copy link

Why unit tests have 100% but coveralls reports 98%? 🤔 https://coveralls.io/jobs/135253050

main and get_arguements appear to be untested. https://coveralls.io/jobs/135253050/source_files/20383741608
All the business logic is in the replicate function though, so this seems fine.

@leplatrem leplatrem merged commit 11f18b9 into main Jan 29, 2024
5 of 6 checks passed
@leplatrem leplatrem deleted the modernize-repo branch January 29, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcottner alexcottner alexcottner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leplatrem @alexcottner