Add Contributing guide #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahildua2305
changed the title
| If you are reporting a bug, please include: | ||
|
|
||
| - Any details about your local setup that might be helpful in troubleshooting. | ||
| - Detailed steps to reproduce the bug. |
There was a problem hiding this comment.
- Detailed steps to reproduce the bug or even a PR with a failing tests if you can.
|
I added some feedback if you want to add them in the file. |
|
@sahildua2305 are you willing to add my feedbacks on your PR? If not can you give me some colab permission on your fork so that I can add my changes there? |
|
@Natim Yes, I will be adding all that in my PR. Give me a day or two, I will update the guide completely 😄 |
|
@sahildua2305 According to https://github.com/Kinto/kinto-http.py/blob/master/Makefile#L34 you do not need to commit config/kinto.ini there. |
|
Ah! That was by mistake. Sorry. I will remove it. |
|
Thank you @sahildua2305 ! |
Sayli-Karnik
added a commit
to Sayli-Karnik/kinto.py
that referenced
this pull request
Oct 15, 2016
leplatrem
added a commit
that referenced
this pull request
Oct 17, 2016
Correct command in contributing guide(Fixes #90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Natim Let's start filling in content for contributing guide 😄