Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POST with If-None-Match: * and provided id in body always return 412 #489

Closed
leplatrem opened this issue Mar 4, 2016 · 4 comments
Closed

POST with If-None-Match: * and provided id in body always return 412 #489

leplatrem opened this issue Mar 4, 2016 · 4 comments
Assignees
@leplatrem
Labels
bug scope: core
Milestone
2.0

Comments

@leplatrem
Copy link
Contributor

Detected using kinto-client v0.4.0 https://github.com/Kinto/kinto-client/blob/v0.4.0/src/requests.js#L188-L205

See mozilla-services/cliquet#673
@n1k0 n1k0 mentioned this issue Mar 4, 2016
Closed
@leplatrem leplatrem removed the protocol label Mar 4, 2016
@n1k0
Copy link
Contributor

n1k0 commented Mar 4, 2016

Note: kinto-client v0.4.1 has been released with an appropriate client-side fix.

@almet
Copy link
Member

almet commented Mar 5, 2016

So I believe we should close this issue!

@almet almet closed this as completed Mar 5, 2016
@n1k0
Copy link
Contributor

n1k0 commented Mar 5, 2016

Well, kinto-client now performs PUT requests only for creations because of this limitation, though there are stil legit use cases for allowing POST methinks. This should be reopened, but I'm not 100% sure so pinging @leplatrem here.

@almet almet reopened this Mar 5, 2016
@leplatrem
Copy link
Contributor Author

The fix was merged in cliquet mozilla-services/cliquet#675

@leplatrem leplatrem self-assigned this Mar 8, 2016
leplatrem added a commit that referenced this issue Mar 8, 2016
@leplatrem
Merge pull request #500 from Kinto/upgrade-cliquet-3.1
46d811b 
Upgrade to cliquet 3.1 (fixes #489)
@leplatrem leplatrem modified the milestone: 1.12 Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leplatrem leplatrem

Labels
bug scope: core
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@n1k0 @almet @leplatrem