Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadTheDocs links to "edit on github" are broken #573

Closed
glasserc opened this issue Apr 29, 2016 · 9 comments
Closed

ReadTheDocs links to "edit on github" are broken #573

glasserc opened this issue Apr 29, 2016 · 9 comments
Labels
bug documentation
Milestone
magopian's third ...

Comments

@glasserc
Copy link
Contributor

In the stable version, they point to version b19b46cbc11ef33305ea4ee7848eee830a07377d. I have no idea why.
@glasserc
Copy link
Contributor Author

glasserc commented May 3, 2016

This appears to be related to readthedocs/readthedocs.org#1820.

@glasserc glasserc mentioned this issue May 31, 2016
Closed
lavish205 pushed a commit to lavish205/kinto that referenced this issue Jun 20, 2016
@Natim
Merge pull request Kinto#573 from mozilla-services/plug-permission-ba…
26f48ef 
…ckend-principals

Fix principals of permission backend not being plugged by default
@magopian
Copy link
Contributor

Submitted a PR to address this issue: readthedocs/readthedocs.org#2428

@leplatrem
Copy link
Contributor

Resolved upstream

@glasserc
Copy link
Contributor Author

As far as I can tell, it hasn't yet been.

@glasserc glasserc reopened this Mar 14, 2017
@Natim
Copy link
Member

Natim commented Apr 28, 2017

See readthedocs/readthedocs.org#1820

@leplatrem leplatrem mentioned this issue May 2, 2017
Closed
@leplatrem
Copy link
Contributor

A new fix was proposed upstream readthedocs/readthedocs.org#3302

@leplatrem
Copy link
Contributor

Bug still there ;)

@magopian
Copy link
Contributor

Seems the fix in the above PR on readthedocs was reverted, and the current issue tracking it is readthedocs/readthedocs.org#3441 (some issue with the git version used on their servers if I understand correctly?)

@glasserc glasserc mentioned this issue Apr 6, 2018
Merged
@magopian
Copy link
Contributor

magopian commented Jun 4, 2018

This now seems fixed, see readthedocs/readthedocs.org#1820

@magopian magopian closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
magopian's third quarter
Development

No branches or pull requests
4 participants
@glasserc @magopian @Natim @leplatrem