Update to Pyramid 1.8 #1087
Merged
Update to Pyramid 1.8 #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyramid moved this out of the class and into its own function.
|
The failing tests are because of Pylons/pyramid#2958 |
Natim
force-pushed
the
birdbrained-patch-2
branch
from
96837de
to
396a990
Compare
|
Note: The next release of Pyramid should not alter the incoming settings. |
gabisurita
approved these changes
Feb 16, 2017
docs/core/resource.rst
Outdated
| @@ -198,7 +198,7 @@ As an example, let's build a code that will copy a collection into another: | |||
| from pyramid import Configurator | |||
|
|
|||
|
|
|||
| config = Configurator(settings=DEFAULT_SETTINGS) | |||
| config = Configurator(settings={**DEFAULT_SETTINGS}) | |||
There was a problem hiding this comment.
Is a shallow copy here enough? Maybe it's a good idea to note with XXX that this is a bug on pyramid.
There was a problem hiding this comment.
Our default_settings aren't nested so yes I think it is enough.
Maybe we don't need to update the documentation about it.
The bug in Pyramid will probably be merged on Sunday but at first they said it was a feature and not a bug...
|
So wait, finally we're not doing a shallow copy or anything? |
We don't have to because the last release of Pyramid 1.8 has my patch with a fix there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1008
Revamp #1016