Fix pserve argument ordering. #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
approved these changes
Feb 21, 2017
kinto/__main__.py
Outdated
| pserve_argv.append('http_port={}'.format(parsed_args['port'])) | ||
| pserve.main(pserve_argv) | ||
| print(pserve_argv) |
There was a problem hiding this comment.
left over or useful info?
kinto/__main__.py
Outdated
| if parsed_args['reload']: | ||
| pserve_argv.append('--reload') | ||
| pserve_argv.append('-v') |
There was a problem hiding this comment.
should we add this only if our verbose option is set?
|
The fact that the argument order is important seems like a bug; should we report it upstream? |
We have the exact same issue with kinto and subcommands. The command help explicits it so it doesn't seems like a bug to me. |
added 3 commits
March 3, 2017 18:21
added 2 commits
March 3, 2017 18:29
gabisurita
approved these changes
Mar 3, 2017
Natim
commented
Mar 3, 2017
tests/test_main.py
Outdated
| res = main(['--ini', TEMP_KINTO_INI, 'start', '-v']) | ||
| assert res == 0 | ||
| assert mocked_pserve.call_count == 1 | ||
| assert mocked_pserve.call_args_list[0][1]['argv'][1] == '-v' |
There was a problem hiding this comment.
We could probably use call_args instead of call_args_list.
Natim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: Pylons/pyramid#2962
Fixes #1092