Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref #3407: Prepare path from Statsd to Prometheus #3449

Merged
merged 14 commits into from
Oct 10, 2024
Merged

Ref #3407: Prepare path from Statsd to Prometheus #3449

merged 14 commits into from
Oct 10, 2024

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Oct 7, 2024 •
edited
Loading

Ref #3407

  • Move statsd out of core
  • Deprecate statsd usage
  • Define generic metrics interface
  • Adjust docs
  • Introduce kinto.plugins.promotheus --> another PR

@leplatrem leplatrem marked this pull request as ready for review October 9, 2024 15:37
@leplatrem leplatrem changed the title Prepare path from Statsd to Prometheus Ref #3407: Prepare path from Statsd to Prometheus Oct 9, 2024
alexcottner
alexcottner approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leplatrem
Copy link
Contributor Author

I'm merging this one, and work can continue in #3453
@grahamalama I'll address your comments in a follow-up if you have any

@leplatrem leplatrem merged commit 9f8ed40 into main Oct 10, 2024
19 checks passed
@leplatrem leplatrem deleted the statsd_to_prometheus branch October 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcottner alexcottner alexcottner approved these changes

@grahamalama grahamalama Awaiting requested review from grahamalama

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leplatrem @alexcottner