Delete buckets and collections #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
leplatrem
force-pushed
the
delete-buckets-collections
branch
2 times, most recently
from
5068244
to
c15000b
Compare
leplatrem
force-pushed
the
delete-buckets-collections
branch
from
c15000b
to
dd07d4d
Compare
leplatrem
changed the title
leplatrem
force-pushed
the
delete-buckets-collections
branch
from
6a94f71
to
195aa8a
Compare
| **Protocol** | ||
|
|
||
| - Delete every (writable) buckets using ``DELETE /v1/buckets`` | ||
| - Delete every (writable) collections using ``DELETE /v1/buckets/<>/collections`` |
There was a problem hiding this comment.
Did you want a <bucket id> here instead of <>?
|
From what I understand of the code I read, this looks good to me. If someone else with better knowledge of the codebase could double-check, that would be nice ;) There's a test failure, from the load tests, is it related to what you were discussing with @Natim on irc about cliquet having timestamp unicity issues? |
leplatrem
force-pushed
the
delete-buckets-collections
branch
from
195aa8a
to
ef25f5f
Compare
* Use recent permission.remove_principal() method * Use ACTIONS constants
leplatrem
force-pushed
the
delete-buckets-collections
branch
from
065242f
to
9cdedbf
Compare
leplatrem
added a commit
that referenced
this pull request
Mar 7, 2016
Delete buckets and collections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was add consistency in kinto.py, I realized that we could had
DELETEendpoints to buckets and collections.Of course, it deletes only the buckets/collections where the user has write permissions.