Kinto creates blank record on Content-Type:text/plain

[Natim]

As Kinto is JSON Datastore and whenever we POST text/plain instead of JSON it creates a blank record in DB instead of rejecting text/plain requests.

Request:

echo '{"data": {"description": "xyz"}}' | http POST http://localhost:8080/v1/buckets/default/collections/test-collection/records Content-Type:text/plain  -v --auth 'token:my-secret'

POST /v1/buckets/default/collections/test-collection/records HTTP/1.1
Accept: application/json
Accept-Encoding: gzip, deflate
Authorization: Basic dG9rZW46bXktc2VjcmV0
Connection: keep-alive
Content-Length: 33
Content-Type: text/plain
Host: localhost:8080
User-Agent: HTTPie/0.9.2

{"data": {"description": "xyz"}}

Response :

HTTP/1.1 201 Created
Access-Control-Expose-Headers: Retry-After, Content-Length, Alert, Backoff
Connection: keep-alive
Content-Length: 187
Content-Type: application/json; charset=UTF-8
Date: Thu, 25 Feb 2016 10:46:57 GMT
Server: nginx/1.8.0

{
    "data": {
        "id": "1227cf0c-66a5-4620-a178-255e7f479f28",
        "last_modified": 1456417017195
    },
    "permissions": {
        "write": [
            "basicauth:157beded4ea96ad4a21ed7fd91fff2a92a5daf47f054877d2e9768259e61600c"
        ]
    }
}

[Natim]

You are right we should return a 415 Unsupported Media Type error

[Natim]

Surprisingly, there are tests about that in cornice: https://github.com/mozilla-services/cornice/blob/master/cornice/tests/test_validation.py#L192-L228

[Natim]

I have added failing tests so that we can investigate why cornice doesn't catch the matter.

[Natim]

Tests are passing with this branch: https://github.com/mozilla-services/cliquet/pull/667/files

[Natim]

I can also duplicate this code in groups/buckets and collection if you think it is a good idea to do it.

Since the code is in Cliquet it is unlikely that they will fail if the other one passes.
It is just some functional tests to make sure that what we want for Kinto is working regardless of cornice or cliquet changes.

[ayusharma]

I got it working.

If we define the content_type while registering a service in cornice, the corince would take it as a default validator. link : http://cornice.readthedocs.org/en/latest/validation.html#content-type-validation

so I have changed code in https://github.com/mozilla-services/cliquet/blob/master/cliquet/resource/__init__.py#L70-L79

service = Service(name, path, depth=depth,content_type="application/json",
                          **viewset.get_service_arguments())

and it gives the response on content-type: text/plain as :

{"errno":107,"message":"Content-Type header should be one of ['application\/json']","code":400,"details":[{"location":"header","name":"Content-Type","description":"Content-Type header should be one of ['application\/json']"}],"error":"Invalid parameters"}

I came across this conversation Cornices/cornice#192

[Natim]

Waiting on mozilla-services/cliquet#667 to get merged

[Natim]

mozilla-services/cliquet#667 has been merged.

[Natim]

Test are passing on cliquet master: https://travis-ci.org/Kinto/kinto/jobs/112033653

We need a release before merging this.