-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate objects after deletion fails #512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
changed the title
Write tests to show the problem.
Recreate objects after deletion fails
Apr 11, 2016
leplatrem
added a commit
to mozilla-services/cliquet
that referenced
this pull request
Apr 11, 2016
I could fix the problem easily :) |
def test_records_can_be_created_after_deletion(self): | ||
self.app.delete(self.record_url, | ||
headers=self.headers, | ||
status=200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 200 is superfluous
Natim
added a commit
to mozilla-services/cliquet
that referenced
this pull request
Apr 19, 2016
…-none-match Fix safe creation a record used to exist with same id (Kinto/kinto#512)
The problem have been merged into Cliquet master. |
Tests are passing with cliquet-master. We can/should wait for a cliquet release before merging. |
cliquet 3.1.2 have been released with this fix. |
Tests are now green 👍 |
lavish205
pushed a commit
to lavish205/kinto
that referenced
this pull request
Jun 20, 2016
lavish205
pushed a commit
to lavish205/kinto
that referenced
this pull request
Jun 20, 2016
Add simple loadtest on PostgreSQL (fixes Kinto#512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kinto.py is struggeling recreating collection, buckets, groups and records with the
safe=True
flag if they have been deleted.These are the test cases that are covering the matter.