Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate objects after deletion fails #512

Merged
merged 2 commits into from
Apr 19, 2016
Merged

Conversation

Natim
Copy link
Member

@Natim Natim commented Mar 17, 2016

kinto.py is struggeling recreating collection, buckets, groups and records with the safe=True flag if they have been deleted.

These are the test cases that are covering the matter.

@leplatrem leplatrem changed the title Write tests to show the problem. Recreate objects after deletion fails Apr 11, 2016
leplatrem added a commit to mozilla-services/cliquet that referenced this pull request Apr 11, 2016
@leplatrem
Copy link
Contributor

I could fix the problem easily :)

def test_records_can_be_created_after_deletion(self):
self.app.delete(self.record_url,
headers=self.headers,
status=200)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 200 is superfluous

Natim added a commit to mozilla-services/cliquet that referenced this pull request Apr 19, 2016
…-none-match

Fix safe creation a record used to exist with same id (Kinto/kinto#512)
@Natim
Copy link
Member Author

Natim commented Apr 19, 2016

The problem have been merged into Cliquet master.

@Natim
Copy link
Member Author

Natim commented Apr 19, 2016

Tests are passing with cliquet-master. We can/should wait for a cliquet release before merging.

@almet
Copy link
Member

almet commented Apr 19, 2016

@Natim
Copy link
Member Author

Natim commented Apr 19, 2016

cliquet 3.1.2 have been released with this fix.

@Natim
Copy link
Member Author

Natim commented Apr 19, 2016

Tests are now green 👍

@Natim Natim merged commit 0bf2fe5 into master Apr 19, 2016
@Natim Natim deleted the recreate_after_deletion_fails branch April 19, 2016 13:14
@Natim Natim removed the in progress label Apr 19, 2016
lavish205 pushed a commit to lavish205/kinto that referenced this pull request Jun 20, 2016
lavish205 pushed a commit to lavish205/kinto that referenced this pull request Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants