Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset settings resets all settings versus scoped to the pane #2435

Closed
jessfraz opened this issue May 21, 2024 · 3 comments · Fixed by #3855
Closed

reset settings resets all settings versus scoped to the pane #2435

jessfraz opened this issue May 21, 2024 · 3 comments · Fixed by #3855
Assignees
Labels
bug Something isn't working

Comments

@jessfraz
Copy link
Contributor

as a part of #2434 i found this, now when I wrote the test in #2434 i assumed it worked in a scoped way so basically once this bug is fixed we just need to change the values that broke in the test haha

@jessfraz jessfraz added the bug Something isn't working label May 21, 2024
@jessfraz jessfraz added this to the v1 Modeling App Launch milestone May 21, 2024
@franknoirot
Copy link
Collaborator

Sorry the wording is confusing me and my memory is failing me @jessfraz. Currently we reset all settings regardless of pane based on what I just checked. And this bug says that it should be scoped to the current settings pane the user is hitting the Reset Settings button on. Am I understanding that correctly?

@jessfraz
Copy link
Contributor Author

jessfraz commented Jul 9, 2024

yes if thats what we want... i think thats what i expected so i was confused

@franknoirot
Copy link
Collaborator

Cool yeah that makes sense to me, won't be hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants