Make settings reset button only reset current level #3855
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // We instead pass in the default directory since it's asynchronous | ||
| // to re-initialize, and that can be done by the caller. | ||
| newSettings.app.projectDirectory.default = event.defaultDirectory | ||
| if (!('level' in event)) return {} |
There was a problem hiding this comment.
That's a neat one. Why not if (!event.level) ?
There was a problem hiding this comment.
It's the same in this case! I could totally do that, and it's probably a hair better.
In other type narrowing for these XState events we'll have data objects and have to narrow based on the keys within the data object, that may or may not exist. TS will yell at you if you try to type narrow in that instance with something like (!event.data?.innerKey), so you have to narrow with something like (!('data' in event && event.data.innerKey)). So I've just matched that idiom.
There was a problem hiding this comment.
From what I understand all data in XState (5) is strongly typed, so I'd be surprised if we ever need in but please ping me so I can collect some examples for the ol' brain vault :D
Closes #2435, updates an E2E test mentioned in 2435 to expect this new scoped behavior.