Add actual argument type to error message #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
force-pushed
the
jtran/improve-arg-error-message
branch
from
e66f3ce
to
2931294
Compare
jtran
force-pushed
the
jtran/improve-arg-error-message
branch
from
97024c3
to
31f34df
Compare
jtran
force-pushed
the
jtran/improve-arg-error-message
branch
from
31f34df
to
3751fe0
Compare
jtran
force-pushed
the
jtran/improve-arg-error-message
branch
from
3751fe0
to
4c62326
Compare
jtran
force-pushed
the
jtran/improve-arg-error-message
branch
from
4c62326
to
74d5ed6
Compare
jtran
force-pushed
the
jtran/improve-arg-error-message
branch
from
5241f75
to
d68c11e
Compare
jtran
force-pushed
the
jtran/improve-arg-error-message
branch
from
d68c11e
to
8f32150
Compare
jtran
force-pushed
the
jtran/improve-arg-error-message
branch
from
2930aa0
to
14dc5f4
Compare
|
turning on auto merge rust tests all good locally, just engines are getting saturated so might be flakey |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3338.
Before, we only showed the expected type, not the actual type.