Add 'relative: bool' to tanArcTo, remove 'to' mode from tanArc #3705
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Pretty sure these need to get updated. modeling-app/src/lang/std/sketch.ts Lines 852 to 853 in 1162ff3 The argument defaults to |
adamchalmers
force-pushed
the
achalmers/again-fucking-tan-rebased
branch
2 times, most recently
from
3488086
to
3af8b57
Compare
|
Sorry, I meant when we call getTag: getTag(3),
addTag: addTag(3),modeling-app/src/lang/std/sketch.ts Lines 852 to 853 in 1162ff3 |
adamchalmers
force-pushed
the
achalmers/again-fucking-tan-rebased
branch
from
d241fef
to
6b88469
Compare
adamchalmers
force-pushed
the
achalmers/again-fucking-tan-rebased
branch
from
f5f72f7
to
9a51e8c
Compare
| @@ -309,7 +309,7 @@ function singleRawValueHelper( | |||
| ] | |||
| } | |||
|
|
|||
| function getTag(index = 2): SketchLineHelper['getTag'] { | |||
| function getTag(index = 3): SketchLineHelper['getTag'] { | |||
There was a problem hiding this comment.
Sorry if I wasn't clear. I think we want to revert this change because it applies to all AST functions, not just tanArcTo.
| function getTag(index = 3): SketchLineHelper['getTag'] { | |
| function getTag(index = 2): SketchLineHelper['getTag'] { |
| @@ -1860,7 +1861,7 @@ function isAngleLiteral(lineArugement: Expr): boolean { | |||
|
|
|||
| type addTagFn = (a: AddTagInfo) => { modifiedAst: Program; tag: string } | Error | |||
|
|
|||
| function addTag(tagIndex = 2): addTagFn { | |||
| function addTag(tagIndex = 3): addTagFn { | |||
There was a problem hiding this comment.
Revert here also.
| function addTag(tagIndex = 3): addTagFn { | |
| function addTag(tagIndex = 2): addTagFn { |
| @@ -849,8 +850,8 @@ export const tangentialArcTo: SketchLineHelper = { | |||
| pathToNode, | |||
There was a problem hiding this comment.
Above and below here are AST mod stuff specific to tangentialArcTo, so I suspect we need to change more stuff in this block.
Fixes #3319