Fix flash of white background in electron dark mode #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franknoirot
commented
Sep 5, 2024
jessfraz
approved these changes
Sep 5, 2024
Merged
This was referenced Sep 5, 2024
franknoirot
added a commit
that referenced
this pull request
Sep 9, 2024
lf94
pushed a commit
that referenced
this pull request
Sep 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user has dark mode set on their OS, they still see a flash of white whenever the app is opened or refreshed. This fixes that by setting the Electron window background to a theme-appropriate value.
Sources
Demo
Screenshare.-.2024-09-05.11_22_30.AM-compressed.mp4