Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renames sketch group/extrude group #4016

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Sep 27, 2024

closes #3906

NOTE: There is a breaking change on this where if you want to get the sketch tags out of a solid, instead of doing part001.sketchGroup.tags you do part001.sketch.tags which is better.

Copy link

qa-wolf bot commented Sep 27, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 27, 2024 10:17pm

Copy link
Contributor

@jtran jtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Signed-off-by: Jess Frazelle <github@jessfraz.com>

updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

fixups

Signed-off-by: Jess Frazelle <github@jessfraz.com>

updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

udpates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

fix parse

Signed-off-by: Jess Frazelle <github@jessfraz.com>

fix typos

Signed-off-by: Jess Frazelle <github@jessfraz.com>

docs

Signed-off-by: Jess Frazelle <github@jessfraz.com>

update tests

Signed-off-by: Jess Frazelle <github@jessfraz.com>

empty
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz force-pushed the rename-extrude-group-and-friends branch from 8ec5adc to 65c49db Compare September 27, 2024 21:30
jessfraz and others added 5 commits September 27, 2024 14:34
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 92.34303% with 50 lines in your changes missing coverage. Please review.

Project coverage is 87.10%. Comparing base (6303130) to head (36e5ce7).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/executor.rs 65.82% 27 Missing ⚠️
src/wasm-lib/kcl/src/std/patterns.rs 96.11% 4 Missing ⚠️
src/wasm-lib/kcl/src/std/segment.rs 80.00% 4 Missing ⚠️
src/wasm-lib/kcl/src/std/sketch.rs 98.13% 4 Missing ⚠️
src/wasm-lib/kcl/src/ast/types.rs 80.00% 3 Missing ⚠️
src/wasm-lib/kcl/src/std/shell.rs 91.30% 2 Missing ⚠️
src/wasm-lib/kcl/src/std/array.rs 83.33% 1 Missing ⚠️
src/wasm-lib/kcl/src/std/extrude.rs 96.66% 1 Missing ⚠️
src/wasm-lib/kcl/src/std/fillet.rs 92.30% 1 Missing ⚠️
src/wasm-lib/kcl/src/std/loft.rs 87.50% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4016      +/-   ##
==========================================
+ Coverage   87.08%   87.10%   +0.01%     
==========================================
  Files          71       71              
  Lines       25360    25291      -69     
==========================================
- Hits        22086    22030      -56     
+ Misses       3274     3261      -13     
Flag Coverage Δ
wasm-lib 87.10% <92.34%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz merged commit e50de13 into main Sep 27, 2024
31 checks passed
@jessfraz jessfraz deleted the rename-extrude-group-and-friends branch September 27, 2024 22:44
@nadr0 nadr0 mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renaming SketchGroup/ExtrudeGroup / consistent naming
2 participants