Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to allow clients to connect to servers that are self-signed #24

Merged
merged 2 commits into from
May 11, 2017

Conversation

niklassaers
Copy link
Contributor

While developing Bolt-swift, I needed to connect via SSL to a server instance running on my laptop that used a self-signed certificate. This adds support for that in BlueSSLService

It has so far only been tested by me with the Neo4j server on my local machine

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@billabt
Copy link
Collaborator

billabt commented May 7, 2017

@niklassaers: The build is failing on Linux. The definition of errSSLServerAuthCompleted was changed to errSSLPeerAuthCompleted and is included in macOS. The errSSLServerAuthCompleted was removed from macOS in version 10.8 and replaced with errSSLPeerAuthCompleted. Removing the old definition and changing where you used it to the new definition should fix the problem. Please make those changes and resubmit the PR. Thanks for contribution.

@niklassaers
Copy link
Contributor Author

Thanks Bill, I've made the update and tested it with Linux

@billabt billabt merged commit 7f5a67c into Kitura:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants