Fix index out of bounds issue on items #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(even thous staus was 0)
Not sure why Xcode didn’t do this by default
This is getting embarrasing. How do I make Xcode match the style / use tabs? Missed these two
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case where items becomes empty, even though p12Data contains data, passwd is correct, and status returns 0. I believe the case is when I'm running as a user who isn't logged in on the system at the moment, because the user it's happening for is "jenkins". Will investigate that further, but the consequence of this is that "newArray.object(at: 0)" would become an index out of bounds error. So this PR tests for that and provides an error instead
Sorry about the indentation-nonsense in the commits.