Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Carthage support #45

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Complete Carthage support #45

merged 2 commits into from
Nov 27, 2017

Conversation

niklassaers
Copy link
Contributor

To complete issue #44, this PR adds the missing Carthage support (Cartfile + make framework a shared scheme) and makes tvOS support explicit so Carthage won't complain about unexpected key tvOS.

Motivation and Context

Add Carthage support to complete issue #44

How Has This Been Tested?

Built locally

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

(I don't believe the two last points to be applicable, do correct me if I'm wrong and I should add it somewhere)

@niklassaers niklassaers mentioned this pull request Nov 25, 2017
@billabt billabt merged commit ccccbc0 into Kitura:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants