Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit connection earlier #244

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Limit connection earlier #244

wants to merge 3 commits into from

Conversation

mbarnach
Copy link
Member

As pointed by @Davidde94 (#242), the connection should be closed earlier than on the end of the request.
This avoid dumping massive amount of data before checking the connection limit.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mbarnach mbarnach mentioned this pull request Sep 28, 2020
Open
Davidde94
Davidde94 approved these changes Sep 29, 2020
View reviewed changes
Copy link

@Davidde94 Davidde94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbarnach mbarnach requested a review from dannys42 September 30, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davidde94 Davidde94 Davidde94 approved these changes

@dannys42 dannys42 Awaiting requested review from dannys42

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbarnach @Davidde94