Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift 4 support #20

Merged
merged 3 commits into from
Sep 25, 2017
Merged

Add Swift 4 support #20

merged 3 commits into from
Sep 25, 2017

Conversation

quanvo87
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 25, 2017

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files           9        9           
  Lines         471      471           
=======================================
  Hits          426      426           
  Misses         45       45
Flag Coverage Δ
#KituraWebSocket 90.44% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d778fe...9f4bbdf. Read the comment docs.

Copy link
Contributor

@youming-lin youming-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// Targets can depend on other targets in this package, and on products in packages which this package depends on.
.target(
name: "KituraWebSocket",
dependencies: ["Kitura-net", "Cryptor"]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be KituraNet instead

@youming-lin youming-lin merged commit 312fd9a into master Sep 25, 2017
@youming-lin youming-lin deleted the swift4 branch September 25, 2017 20:54
@youming-lin
Copy link
Contributor

Kitura/Kitura#1121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants