Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve deprecation warnings for swift 4.1 #33

Merged
merged 2 commits into from
Mar 22, 2018

Conversation

ShihabMehboob
Copy link
Contributor

Replaces 'copyBytes(from:count:)' with 'copyMemory(from:byteCount:)' to silence swift 4.1 deprecation warnings.

@helenmasters
Copy link
Contributor

@ShihabMehboob please can you look into the Travis build failures.

@codecov-io
Copy link

Codecov Report

Merging #33 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage    91.3%   91.51%   +0.21%     
==========================================
  Files           9        9              
  Lines         483      495      +12     
==========================================
+ Hits          441      453      +12     
  Misses         42       42
Flag Coverage Δ
#KituraWebSocket 91.51% <100%> (+0.21%) ⬆️
Impacted Files Coverage Δ
Sources/KituraWebSocket/WSFrame.swift 100% <100%> (ø) ⬆️
Sources/KituraWebSocket/WSFrameParser.swift 98.31% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b6ae1...78b0733. Read the comment docs.

@ShihabMehboob ShihabMehboob requested a review from EnriqueL8 March 22, 2018 09:26
Copy link

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShihabMehboob ShihabMehboob merged commit 09c030f into master Mar 22, 2018
@ShihabMehboob ShihabMehboob deleted the swift41.warnings branch March 22, 2018 11:23
KyeMaloy97 pushed a commit that referenced this pull request Apr 13, 2018
Resolved deprecation warnings for swift 4.1 and added swift4.1 checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants