close on invalid UTF-8 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianpartridge
requested changes
Apr 12, 2018
| part = self.payload(text: "Failed to convert received payload to UTF-8 String") | ||
| expectedPayload.append(part.bytes, length: part.length) | ||
|
|
||
| self.performTest(framesToSend: [(true, self.opcodeText, textPayload as NSData)], |
There was a problem hiding this comment.
This doesn't work on Linux because there's no bridging.
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=========================================
+ Coverage 91.51% 92.12% +0.6%
=========================================
Files 9 9
Lines 495 495
=========================================
+ Hits 453 456 +3
+ Misses 42 39 -3
Continue to review full report at Codecov.
|
ianpartridge
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the websocket server close the connection on receiving invalid UTF-8 and return the error message:
Failed to convert received payload to UTF-8 String
A new test has been added which sends invalid utf-8 and expects to receive this error code.