Fix: respond with correct reason code #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nethraravindran
approved these changes
Sep 27, 2018
|
LGTM :) |
| guard frame.finalFrame else { | ||
| connectionClosed(reason: .protocolError, description: "Control frames must not be fragmented") | ||
| return | ||
| if active { |
There was a problem hiding this comment.
Would guard active else { break } be better, to avoid the indentation?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the websocket protocol you are not supposed to send the reason code noReasonCodeSent. This is meant to be used internally to represent no code being sent. You then respond with a normal close to the client.
This PR changes our behavior on receiving no reason code to match the protocol.
It also sends the correct reason code to the client when we terminate them for not responding to a ping.
It also makes the service only respond to a ping if the connection is active to make autobahn test 7.1.3 pass.
Websockets with these changes have been run against autobahn and all tasts pass.