Fix a memory leak that occurs with keep alive #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a memory leak that occurs when sockets kept open due to keep alive are finally closed due to inactivity.
Description
When sockets are closed due to inactivity make sure that the IncomingSocketProcessor.prepareToClose() function is called. This will break the retain loop between the HTTPIncomingMesage and the HTTPParser.
Motivation and Context
Fixes a memory lak reported in isuue Kitura/Kitura#902
How Has This Been Tested?
@djones tested using Safari and determined that the memory leak was fixed.
Ran KituraNet unit tests on macOS and Linux.
Checklist: