Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard socket read(), write(), close() race conditions and use SSL tests #169

Merged
merged 3 commits into from
Jan 19, 2017

Conversation

na-gupta
Copy link
Contributor

Description

  • Add state guards for IncomingSocketHandler read() write() and close() functions
  • Make sure we don't close sockets while they're being used or try to use them after they're closed
  • Make most unit tests use SSLService as it surfaces race condition problems whereas Socket mostly ignores them

Motivation and Context

Kitura/Kitura#959
Kitura/Kitura#962

How Has This Been Tested?

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@na-gupta na-gupta requested a review from shmuelk January 18, 2017 05:15
@codecov-io
Copy link

codecov-io commented Jan 18, 2017

Current coverage is 83.56% (diff: 67.74%)

Merging #169 into master will decrease coverage by 0.08%

@@             master       #169   diff @@
==========================================
  Files            27         27          
  Lines          2348       2373    +25   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1964       1983    +19   
- Misses          384        390     +6   
  Partials          0          0          

Powered by Codecov. Last update b98115b...a36c9c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants