Feat: Add BodyEncoder and BodyDecoder #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| A class that conforms to `BodyDecoder` must be able to decode from `Data` into a `Codable` type. | ||
| This class can then be used to produce input objects for a Codable route. | ||
| */ | ||
| public protocol BodyDecoder { |
There was a problem hiding this comment.
If conformances to this protocol must be classes, then define it as public protocol BodyDecoder: AnyObject {}
| A class that conforms to `BodyEncoder` must be able to encode a `Codable` type into `Data`. | ||
| This class can then be used to produce output objects for a Codable route. | ||
| */ | ||
| public protocol BodyEncoder { |
Andrew-Lees11
force-pushed
the
customCoder
branch
from
e97cbd9 to
996b7bf
Compare
ianpartridge
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds two protocols BodyEncoder and BodyDecoder and extends Query and JSON encoders/decoders to conform to them. These will be used in Kitura for custom enoders/decoders.
This depends on pr 28 which adds an encode to and decode from data to Query encoder and decoder.