Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added QueryEncoder and QueryDecoder support for alternate date formats #45

Merged
merged 18 commits into from
Sep 20, 2019
Merged

Added QueryEncoder and QueryDecoder support for alternate date formats #45

merged 18 commits into from
Sep 20, 2019

Conversation

CameronMcWilliam
Copy link

@CameronMcWilliam CameronMcWilliam commented Sep 12, 2019 •
edited by djones6
Loading

Both QueryEncoder and QueryDecoder now have support for more than just the default formatting, now supports: ISO8601, Custom, Formatting, Date Deferred To and Time Interval Since 1970.

Resolves #41

djones6
djones6 suggested changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - a few comments

Sources/KituraContracts/CodableQuery/Extensions.swift Show resolved Hide resolved
Sources/KituraContracts/CodableQuery/Extensions.swift Outdated Show resolved Hide resolved
Sources/KituraContracts/CodableQuery/QueryDecoder.swift Outdated Show resolved Hide resolved
Sources/KituraContracts/CodableQuery/QueryDecoder.swift Outdated Show resolved Hide resolved
Sources/KituraContracts/CodableQuery/Extensions.swift Show resolved Hide resolved
Sources/KituraContracts/CodableQuery/QueryEncoder.swift Show resolved Hide resolved
Sources/KituraContracts/Contracts.swift Outdated Show resolved Hide resolved
Tests/KituraContractsTests/QueryCoderTests.swift Show resolved Hide resolved
Sources/KituraContracts/CodableQuery/QueryDecoder.swift Outdated Show resolved Hide resolved
Sources/KituraContracts/CodableQuery/QueryEncoder.swift Outdated Show resolved Hide resolved
@djones6 djones6 added the jazzy-doc When applied to a PR, instructs Package-Builder to regenerate the Jazzy documentation label Sep 20, 2019
@djones6 djones6 merged commit bf06108 into Kitura:master Sep 20, 2019
@djones6 djones6 mentioned this pull request Sep 20, 2019
Merged
djones6 added a commit that referenced this pull request Sep 20, 2019
@djones6
docs: Update documentation for #45 (#48)
316e301
@djones6 djones6 mentioned this pull request Sep 20, 2019
Merged
@CameronMcWilliam CameronMcWilliam deleted the dates branch September 30, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djones6 djones6 djones6 approved these changes

Assignees
No one assigned
Labels
jazzy-doc When applied to a PR, instructs Package-Builder to regenerate the Jazzy documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for alternate date encoding strategies in QueryDecoder.
2 participants
@CameronMcWilliam @djones6