Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure a provided db is used to execute Model operations #106

Merged
merged 4 commits into from
Mar 21, 2019
Merged

Ensure a provided db is used to execute Model operations #106

merged 4 commits into from
Mar 21, 2019

Conversation

kilnerm
Copy link
Contributor

@kilnerm kilnerm commented Mar 21, 2019 •
edited by djones6
Loading

This PR updates the ORM to pass a provided Database through functions that accept it to the underlying task execution.

Resolves #100

@kilnerm kilnerm requested a review from djones6 March 21, 2019 10:04
@kilnerm kilnerm self-assigned this Mar 21, 2019
@kilnerm kilnerm added this to the 2019.06 milestone Mar 21, 2019
djones6
djones6 reviewed Mar 21, 2019
View reviewed changes
Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, could we add a test?

@kilnerm kilnerm merged commit ad45dcc into master Mar 21, 2019
@kilnerm kilnerm deleted the use_db branch March 21, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djones6 djones6 djones6 approved these changes

Assignees

@kilnerm kilnerm

Labels
None yet
Projects
None yet
Milestone
2019.06
Development

Successfully merging this pull request may close these issues.
2 participants
@kilnerm @djones6