Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add test for create & drop table #25

Merged
merged 2 commits into from
May 1, 2018
Merged

feat: Add test for create & drop table #25

merged 2 commits into from
May 1, 2018

Conversation

EnriqueL8
Copy link
Contributor

  • Add test for create & drop table
  • Create typealias for SQLDataType

@EnriqueL8 EnriqueL8 self-assigned this Apr 5, 2018
@EnriqueL8 EnriqueL8 requested a review from djones6 April 5, 2018 08:59
@codecov-io
Copy link

codecov-io commented Apr 5, 2018

Codecov Report

Merging #25 into master will increase coverage by 2.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #25     +/-   ##
=========================================
+ Coverage   22.73%   24.93%   +2.2%     
=========================================
  Files           6        6             
  Lines        1500     1500             
=========================================
+ Hits          341      374     +33     
+ Misses       1159     1126     -33
Flag Coverage Δ
#SwiftKueryORM 24.93% <100%> (+2.2%) ⬆️
Impacted Files Coverage Δ
Sources/SwiftKueryORM/Model.swift 28.29% <ø> (+3.24%) ⬆️
Sources/SwiftKueryORM/TableInfo.swift 62% <100%> (+6%) ⬆️
Sources/SwiftKueryORM/TypeDecoder.swift 14.54% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5ddc7...48f9702. Read the comment docs.

@ianpartridge
Copy link

Can we merge this?

@EnriqueL8
Copy link
Contributor Author

waiting on review...

@ianpartridge
Copy link

Oi @djones6 🤣

Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies - this looks good.

@djones6
Copy link
Contributor

djones6 commented May 1, 2018

@EnriqueL8 FYI I resolved a (trivial) merge conflict with #26 where both PRs add a TypeAlias to Model.

@EnriqueL8 EnriqueL8 merged commit 82f8b0b into master May 1, 2018
@EnriqueL8 EnriqueL8 deleted the add_test branch May 1, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants