Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactoring the Model #32

Merged
merged 1 commit into from
May 1, 2018
Merged

fix: Refactoring the Model #32

merged 1 commit into from
May 1, 2018

Conversation

EnriqueL8
Copy link
Contributor

No description provided.

@EnriqueL8 EnriqueL8 self-assigned this Apr 25, 2018
@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #32 into master will increase coverage by 3.16%.
The diff coverage is 38.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   22.73%   25.89%   +3.16%     
==========================================
  Files           6        6              
  Lines        1500     1197     -303     
==========================================
- Hits          341      310      -31     
+ Misses       1159      887     -272
Flag Coverage Δ
#SwiftKueryORM 25.89% <38.56%> (+3.16%) ⬆️
Impacted Files Coverage Δ
Sources/SwiftKueryORM/Model.swift 32.65% <38.56%> (+7.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5ddc7...15ca2ba. Read the comment docs.

Copy link

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the refactorings in here are all good ideas. However the PR is very large and hard to review because there are a number of different refactorings being applied at the same time.

Can we split this into multiple commits so the changes are more granular?

Copy link

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good - the refactorings are a definite improvement. I'm afraid I haven't had time to go through it all line by line :(

@EnriqueL8 EnriqueL8 merged commit 72368ba into master May 1, 2018
@EnriqueL8 EnriqueL8 deleted the refactor branch May 1, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants