Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ClientCertificate init scope public #41

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Make ClientCertificate init scope public #41

merged 1 commit into from
Oct 27, 2018

Conversation

alexhumphreys
Copy link
Contributor

I was trying to initialise this class from another module and ran into the error:

'ClientCertificate' initializer is inaccessible due to 'internal' protection level

From the apple swift docs:

Default Memberwise Initializers for Structure Types
The default memberwise initializer for a structure type is considered private if any of the structure’s stored properties are private. Likewise, if any of the structure’s stored properties are file private, the initializer is file private. Otherwise, the initializer has an access level of internal.

As with the default initializer above, if you want a public structure type to be initializable with a memberwise initializer when used in another module, you must provide a public memberwise initializer yourself as part of the type’s definition.

This PR adds provides that public memberwise initializer.

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2018

CLA assistant check
All committers have signed the CLA.

@ianpartridge ianpartridge self-requested a review October 27, 2018 07:31
@ianpartridge ianpartridge merged commit 4f6584c into Kitura:master Oct 27, 2018
@ianpartridge
Copy link
Contributor

Thanks!

@alexhumphreys alexhumphreys deleted the issue.client-certificate-scope branch October 27, 2018 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants