-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Girder Large Image and Tiled Image Support #1255
Conversation
aea00b3
to
69a676b
Compare
It looks good with some minor issues:
|
url = `${url}?projection=${encodeURIComponent(projection)}`; | ||
} | ||
const { data } = await girderRest.get(url); | ||
// const { data } = await girderRest.get(`item/${itemId}/tiles?projection=EPSG%3A3857`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment can probably be removed
d35922d
to
8aa2542
Compare
7931a75
to
6c1ed32
Compare
6c1ed32
to
6b85fef
Compare
a2ab30f
to
776ebe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Maybe add that tooltip but other than that I think this is gtg
</v-list-item> | ||
<v-list-item> | ||
<import-button | ||
:name="`Add ${pendingUploads.length ? 'Another ' : ''}Tiled Images`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add tooltip that indicates acceptable file types and that it can be a sequence too. Users might try to use the other sequence option otherwise.
I merged it with main to add in the attribute rendering and also added in the tooltip you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
::shipit::
resolves #1253
Features/Code Implemented:
--find-links
for pip install. There is this PR (Equivalent behaviour to pip install --find-links python-poetry/poetry#1511), but it seems the still preferred way is to use direct links to the wheels.DatasetType: 'large-image'
- automatically converts NTFs, NITFs, tiffs and R# files to large image data. This new type can be uploaded using the data importerTesting Procedure:
Testing Dataset zip file(https://viame.kitware.com/api/v1/item/63481282828794fdd97cc03c/download) - warning it is ~1.8GB.
Standard Large Image Testing:
docker-compose build --no-cache
to build the system with the new poetry dependenciesSequenced Large Image Testing:
Auto Conversion of Large JPG/TIF/PNG Images:
TODOs: