Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Update kw-web-suite #8

Merged
merged 4 commits into from
Oct 3, 2019
Merged

BREAKING CHANGE: Update kw-web-suite #8

merged 4 commits into from
Oct 3, 2019

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Sep 30, 2019

This increments the major version for a bunch of packages. See the BREAKING CHANGE commit message for more details.

Ones that likely have the most impact, so may need testing:

css-loader:

  • options for css modules have moved

eslint:

  • stricter on some defaults

Fixes #7

@jourdain

Key points:
- eslint is now stricter
- css-loader css modules options have been moved

Below details some of the major package version upgrades:

eslint 5 to 6:
- https://eslint.org/docs/user-guide/migrating-to-6.0.0
- node 6 not supported
- multiple validation changes

css-loader 1 to 3:
- css modules disabled by default
- min node ver: 8.9.0
- css modules option moved to "modules" key as object (affects
  localIdentName, hashPrefix, etc.)

file-loader 2 to 4:
- removed useRelativePath option
- min webpack 4
- min node: 8.9.0

raw-loader 0.5.1 to 3:
- min node dep 8.9.0

style-loader 0 to 1:
- min node dep 8.9.0
- min webpack 4
- lots of option changes:
  https://github.com/webpack-contrib/style-loader/releases/tag/v1.0.0

svg-sprite-loader 3 to 4:
- safe, no breaking changes despite major bump

url-loader 1 to 2:
- min node 8.9.0
- "limit" param must always be a number

clean-webpack-plugin 0 to 3:
- min node 7
- min webpack 3
- default export is now a named symbol export (CleanWebpackPlugin)

copy-webpack-plugin 4 to 5:
- min node 6.9
- min webpack 4

terser-webpack-plugin 1 to 2:
- min node 8.9.0
- default option value changes (mostly from "false" to "true")

workbox-webpack-plugin 3 to 4:
- workbox is now at v4
- manifest.json is now precached by default

webpack-dashboard 2 to 3:
- min node 8

commitizen 3 to 4:
- remove node 6 and 8 support

cz-conventional-changelog 2 to 3:
- "Node 10 is LTS so please upgrade to it"

size-limit 0 to 2:
- ????? They don't have any notes on this
@floryst
Copy link
Collaborator Author

floryst commented Sep 30, 2019

Note I'm not ready to merge just yet.

@floryst floryst changed the title Update kw-web-suite BREAKING CHANGE: Update kw-web-suite Sep 30, 2019
@floryst
Copy link
Collaborator Author

floryst commented Sep 30, 2019

Ok, there are two reported security vulnerabilities from npm audit. However, it only impacts the tool inline-source-cli, so the vulnerabilities don't affect build outputs.

@floryst floryst merged commit 1727eeb into master Oct 3, 2019
@floryst floryst deleted the update branch October 3, 2019 20:49
@jourdain
Copy link
Collaborator

jourdain commented Oct 3, 2019

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A lot of vulnerabilities
2 participants