-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Junk" removal switch to BCU-Console #581
Add "Junk" removal switch to BCU-Console #581
Conversation
- Added /J parameter and confidence level parsing from the parameter token - Added junk removal logic into RunUninstall method.
Previously the junk search would only occur on apps that were not properly uninstalled. This commit changes this so that all target apps are scanned, regardless of their uninstall status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes look good, but please move the msbuild path change into a separate PR.
It may be better to change /J level
to /J=level
so that a simple string.Split
can be used instead of an error-prone index offset.
that is kinda new to me. as someone who's been using bash for over 2 yrs now, i never thought about this.
7-zip works the same way, but i guess it's just windows things - not aimed at CLI uses 🤷♀️😕 p.s. ohwwww, now i see why windows use backslashes for paths, |
I made the requested reversion on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the PR!
Adds option for BCU-Console to perform junk removal with a
/J <Level>
switch. Includes updates to the documentation files to account for this change. Welcoming of any pointers or improvements that can be made.I also included a change to
publish.bat
to usevswhere.exe
to findMSBuild.exe
. If this needs to be a separate PR I can split them out.