Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Junk" removal switch to BCU-Console #581

Merged
merged 11 commits into from
May 10, 2024

Conversation

theologos7
Copy link
Contributor

Adds option for BCU-Console to perform junk removal with a /J <Level> switch. Includes updates to the documentation files to account for this change. Welcoming of any pointers or improvements that can be made.

I also included a change to publish.bat to use vswhere.exe to find MSBuild.exe. If this needs to be a separate PR I can split them out.

- Added /J parameter and confidence level parsing from the parameter token
- Added junk removal logic into RunUninstall method.
Previously the junk search would only occur on apps that were not properly uninstalled. This commit changes this so that all target apps are scanned, regardless of their uninstall status.
Copy link
Owner

@Klocman Klocman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good, but please move the msbuild path change into a separate PR.

It may be better to change /J level to /J=level so that a simple string.Split can be used instead of an error-prone index offset.

@goyalyashpal
Copy link

goyalyashpal commented Mar 22, 2024

It may be better to change /J level to /J=level so that a simple string.Split can be used instead of an error-prone index offset.

that is kinda new to me. as someone who's been using bash for over 2 yrs now, i never thought about this.

  • the space separation is always convenient to use though.
  • it works much much better when u are entering paths which can use the tab completion from shell

7-zip works the same way, = equals everywhere, which makes it suuuuuuper tedious to use due to lack of tab completions for paths. i ditched using 7zip-cli for that same reason.

but i guess it's just windows things - not aimed at CLI uses 🤷‍♀️😕


p.s.

ohwwww, now i see why windows use backslashes for paths,
'cz it reserves forward slashes for CLI options 🤦🤦🤦
holy god these legacy shackles. windows ssuckss big time each time.

@theologos7 theologos7 requested a review from Klocman March 29, 2024 14:41
@theologos7
Copy link
Contributor Author

I made the requested reversion on the publish.bat file and changed the syntax to /J=<Level>. I did leave the option to just pass /J with no =<Level> which will default to a VeryGood confidence level.

Copy link
Owner

@Klocman Klocman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the PR!

@Klocman Klocman changed the title Add "Junk" Removal to BCU-Console Add "Junk" removal switch to BCU-Console May 10, 2024
@Klocman Klocman merged commit a888058 into Klocman:master May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants