Fix panic when eliding invalid constant cases #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+, >, <, <=, and >= require typechecking of both operands
simultaneously; constant-operand eliding did not perform this check,
causing a panic.
In the below examples,
conditional.go
is a test program I wrote when investigating this library; it is essentially a minimal REPL for govaluate.Before:
After:
The error message is still incorrect, but it's better than a panic. Likely the error message should be something along the lines of
"Values '1' and 'true' cannot be used with the comparator '>'"
.