[debug] improve repository err msg

Knox-AAU · Nov 24, 2023 · db2f199 · db2f199
1 parent 0aae805
commit db2f199
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/pkg/http/rest/acceptance_test.go b/pkg/http/rest/acceptance_test.go
@@ -177,14 +177,7 @@ func doRequest(router *gin.Engine, path string, t *testing.T, _method method, bo
 
 	err = json.NewDecoder(response.Body).Decode(&actualResponse)
 	require.NoError(t, err)
-
-	if actualResponse.ErrMessage != "" {
-		var body interface{}
-		err = json.NewDecoder(response.Body).Decode(&body)
-
-		require.NoError(t, err, actualResponse.ErrMessage)
-		require.Empty(t, actualResponse.ErrMessage, body)
-	}
+	require.Empty(t, actualResponse.ErrMessage)
 
 	return rest.Result{
 		Query:   actualResponse.Query,

diff --git a/pkg/storage/virtuoso/http/repository.go b/pkg/storage/virtuoso/http/repository.go
@@ -63,7 +63,12 @@ func (r virtuosoRepository) ExecuteGET(query string) ([]graph.GetTriple, error)
 
 	virtuosoRes := graph.VirtuosoResponse{}
 	if err := json.Unmarshal(buf.Bytes(), &virtuosoRes); err != nil {
-		return nil, fmt.Errorf("unmarshal response: %w", err)
+		var body interface{}
+		if _err := json.Unmarshal(buf.Bytes(), &body); err != nil {
+			return nil, fmt.Errorf("unmarshal response: %w%w", _err, err)
+		}
+
+		return nil, fmt.Errorf("error unmarshalling response: %s, wanted %T but got %v", err.Error(), virtuosoRes, body)
 	}
 
 	return virtuosoRes.Results.Bindings, nil