Fix composer deprecation notices #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpozzi
commented
Aug 7, 2020
| @@ -10,6 +10,7 @@ env: | |||
| - PHPUNIT_FLAGS="-v" | |||
| - SYMFONY_PHPUNIT_DIR="$HOME/symfony-bridge/.phpunit" | |||
| - SYMFONY_REQUIRE='>=2.8' | |||
| - SYMFONY_DEPRECATIONS_HELPER="weak" | |||
There was a problem hiding this comment.
This has been changed because Symfony deprecations on the router component configuration.
There should probably be better ways to deal with it, maybe with Symfony version's specific configurations but I'm not sure it makes much sense.
I'm open to better ideas!
alexpozzi
commented
Aug 7, 2020
| @@ -15,19 +15,21 @@ | |||
| "homepage": "http://github.com/KnpLabs/KnpSnappyBundle/contributors" | |||
| } | |||
| ], | |||
| "minimum-stability": "dev", | |||
There was a problem hiding this comment.
We should add it back but, unfortunately, Snappy dev-master has some breaking changes (my bad, I'm gonna fix it) and, in order to make tests pass now we have to remove it (some of the tests don't use --prefer-stable composer flag, that's why they fail).
AntoineLelaisant
approved these changes
Aug 12, 2020
This was referenced Sep 11, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-organizes a little this library folder structure and fixes Composer's deprecation notices.
Replaces #261 and #263
Fixes #267