Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c #81

Merged
merged 35 commits into from
Aug 11, 2024
Merged

c #81

merged 35 commits into from
Aug 11, 2024

Conversation

Koeng101
Copy link
Owner

@Koeng101 Koeng101 commented Aug 8, 2024

This adds a c library bindings to dnadesign. Work in progress. Addresses #80

@Koeng101
Copy link
Owner Author

Koeng101 commented Aug 8, 2024

Tradeoffs tradeoffs...

cffi is a very simple system for getting these functions integrated with python. However, no guarantees around typing - meaning I gotta go implement the classes from scratch. However, I think I like this approach more than the approach of using gopy because there is way less going on underneath-the-hood.

Basically, I want to get the minimally viable output python library out as quickly as I can. I think this is going to be just a Fasta parser, with continuous integration and testing (now with python too! Whew!)

@Koeng101
Copy link
Owner Author

Koeng101 commented Aug 10, 2024

Ok, thought a little more about this. Here is what I want:

  • fasta parsing + writing packaged as a C library
  • python with mypy + black + coverage (plus pytest)
  • pytest testing of the functions to show they actually work
  • automatic packaging and releasing of python package
  • sphinx documentation

This is a lot of just continuous development stuff, which honestly is exactly what it is. I think easy interfacing REALLY matters here. So long as I can package it well, and know how the packaging works, we can slowly integrate functionality from the overall library. What matters here is that it works and we have a platform we can get the rest of the code on.

@Koeng101
Copy link
Owner Author

Alright, now we got a package!

@Koeng101
Copy link
Owner Author

https://pypi.org/project/dnadesign/0.1.0/

Let's gooooo!

Still need the automated CI/CD, but confirmed we can upload to pypi which is huge!

@Koeng101
Copy link
Owner Author

Ok, I don't have automatic documentation, but I think this is sufficient for a release, especially to try out what it looks like to publish to pypi, and if that actually works.

@Koeng101 Koeng101 merged commit 6e4611f into main Aug 11, 2024
10 checks passed
@Koeng101 Koeng101 deleted the c branch August 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant