-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fromZigbee.tuya_switch_power_outage_memory doesn't work, because of attribute check #4385
Comments
Could you submit a pr to fix this? |
@Koenkk yes, I can. The simple fix would be to just update the attribute reference in But I wanted to clarify first - do we need both |
Sounds good
Lets keep both since changing this would be somewhat a breaking change. |
…the updated attribute code
…and converter
…d` command converter to match existing behavior
…e code according to cluster definition changes (#4391) * Refs #4385: `tuya_switch_power_outage_memory` converters - use the updated attribute code * Refs #4385: `tuya_switch_power_outage_memory` - add `read` command converter * Refs #4385: `tuya_switch_power_outage_memory` - remove the `read` command converter to match existing behavior
…tribute code according to cluster definition changes (Koenkk#4391) * Refs Koenkk#4385: `tuya_switch_power_outage_memory` converters - use the updated attribute code * Refs Koenkk#4385: `tuya_switch_power_outage_memory` - add `read` command converter * Refs Koenkk#4385: `tuya_switch_power_outage_memory` - remove the `read` command converter to match existing behavior
There is a check for attribute
0x8002
:zigbee-herdsman-converters/converters/fromZigbee.js
Line 7276 in a88c04c
But this attribute is listed under name
moesStartUpOnOff
in cluster definition:moesStartUpOnOff
so the method receives it as a string and the check always fails.
There is also newer
moes_power_on_behavior
converter, which looks similar, but uses correct attribute name:zigbee-herdsman-converters/converters/fromZigbee.js
Line 2561 in a88c04c
At the
toZigbee
side converters look close also, but themoes_power_on_behavior
variant contains theget
converter in addition:zigbee-herdsman-converters/converters/toZigbee.js
Line 2580 in a88c04c
zigbee-herdsman-converters/converters/toZigbee.js
Line 3583 in a88c04c
The text was updated successfully, but these errors were encountered: