Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromZigbee.tuya_switch_power_outage_memory doesn't work, because of attribute check #4385

Closed
gorbunovav opened this issue Jun 26, 2022 · 3 comments · Fixed by #4391
Closed

Comments

@gorbunovav
Copy link
Contributor

There is a check for attribute 0x8002:

const property = 0x8002;

But this attribute is listed under name moesStartUpOnOff in cluster definition:
moesStartUpOnOff
so the method receives it as a string and the check always fails.

There is also newer moes_power_on_behavior converter, which looks similar, but uses correct attribute name:

moes_power_on_behavior: {

At the toZigbee side converters look close also, but the moes_power_on_behavior variant contains the get converter in addition:

tuya_switch_power_outage_memory: {

moes_power_on_behavior: {

@Koenkk
Copy link
Owner

Koenkk commented Jun 27, 2022

Could you submit a pr to fix this?

@gorbunovav
Copy link
Contributor Author

@Koenkk yes, I can.

The simple fix would be to just update the attribute reference in tuya_switch_power_outage_memory.

But I wanted to clarify first - do we need both moes_power_on_behavior and tuya_switch_power_outage_memory converters or can they be merged?

@Koenkk
Copy link
Owner

Koenkk commented Jun 28, 2022

The simple fix would be to just update the attribute reference in tuya_switch_power_outage_memory.

Sounds good

But I wanted to clarify first - do we need both moes_power_on_behavior and tuya_switch_power_outage_memory converters or can they be merged?

Lets keep both since changing this would be somewhat a breaking change.

gorbunovav added a commit to gorbunovav/zigbee-herdsman-converters that referenced this issue Jun 28, 2022
gorbunovav added a commit to gorbunovav/zigbee-herdsman-converters that referenced this issue Jun 28, 2022
gorbunovav added a commit to gorbunovav/zigbee-herdsman-converters that referenced this issue Jun 28, 2022
…d` command converter to match existing behavior
Koenkk pushed a commit that referenced this issue Jun 29, 2022
…e code according to cluster definition changes (#4391)

* Refs #4385: `tuya_switch_power_outage_memory` converters - use the updated attribute code

* Refs #4385: `tuya_switch_power_outage_memory` - add `read` command converter

* Refs #4385: `tuya_switch_power_outage_memory` - remove the `read` command converter to match existing behavior
Mephistofeles pushed a commit to Mephistofeles/zigbee-herdsman-converters that referenced this issue Dec 13, 2022
…tribute code according to cluster definition changes (Koenkk#4391)

* Refs Koenkk#4385: `tuya_switch_power_outage_memory` converters - use the updated attribute code

* Refs Koenkk#4385: `tuya_switch_power_outage_memory` - add `read` command converter

* Refs Koenkk#4385: `tuya_switch_power_outage_memory` - remove the `read` command converter to match existing behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants