-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert IKEA to modern extend #7220
Conversation
return {configure, isModernExtend: true}; | ||
} | ||
|
||
export function ikeaAirPurifier(): ModernExtend { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably more readable to split these into multiple modernExtends e.g.
- ikeaAirPurifierPm25
- ikeaAirPurifierFilterRunTime
- ikeaAirPurifierControlPanelLight
- ikeaAirPurifierChildLock
- ikeaAirPurifierFanSpeed
- ikeaAirPurifierFanMode
Each just having the expose, fromZigbee, toZigbee and configure that is relevant for the attribute.
I think I actually have a branch with that somewhere but I never finished it because E_NOTIME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary though? It’s not like this is going to be reused in parts anyway. Everything here comes from the same ikea purifier specific cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally it won't make much difference, just readability.
I'll probably eventually do it myself, the current blob of code is not very readable. The person who originally wrote it did not do a very good job at keeping it readable. (I wrote it so It's OK to say it without offending anyone)
@mrskycriper will merge it after the 1 April release. |
Thanks! |
TODO
lib/ikea.ts
Additional
Modern extend improvements
Partial solution for Koenkk/zigbee2mqtt#21951
Model changes
LED1923R5/LED1925G6
toLED1923R5
(LED1925G6 already exists)ICPSHC24-10EU-IL-1
toICPSHC24-10EU-IL-1/ICPSHC24-10EU-IL-2
(same Zigbee model)ICPSHC24-30EU-IL-1
toICPSHC24-30EU-IL-1/ICPSHC24-30EU-IL-2
(same Zigbee model)LED1934G3_E26
andLED1934G3_E27
toLED1934G3
(same bulbs, different sockets)LED1937T5_E26
andLED1937T5_E27
toLED1937T5
(same bulbs, different sockets)LED1903C5/LED1835C6
toLED1835C6
(LED1903C5 is a dumb dimmable LEDARE bulb)Images for renamed models: Koenkk/zigbee2mqtt.io#2662