-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modern extend improvements #7239
feat: modern extend improvements #7239
Conversation
@Koenkk implemented all suggested changes |
Many thanks for another great refactor 😄 |
This comment was marked as outdated.
This comment was marked as outdated.
@Koenkk Just realized we have no option to configured reporting for zigbee-herdsman-converters/src/lib/modernExtend.ts Lines 270 to 290 in f7993f5
Do some devices report zigbee-herdsman-converters/src/lib/modernExtend.ts Lines 318 to 340 in f7993f5
|
Some devices might report it on their own, but the question is wether we want to batteryAlarmState to be reported when we already have the battery % |
Yea, kinda hard to know which devices actually do report it on their own... |
TODO
identify
extendlinkquality
extendpm25
extendcommandsOnOff
extendcommandsLevelCtrl
extendcommandsColorCtrl
extendcommandsWindowCovering
extendwindowCovering
extenddeviceTemperature
extendflow
extendsoilMoisture
extendidentify
to inputExtendersota
extend to definition generator