Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct get/set position for bticino 4027C #2487

Merged
merged 5 commits into from
Apr 18, 2021
Merged

Conversation

PxPert
Copy link
Contributor

@PxPert PxPert commented Apr 17, 2021

Newer 4027C firmware Is infact capable of Get and Set correct positions between 0 and 100.
I've added support for partial position setting and reporting.
Optionally, in case of old firmware that doesn't support position reporting, it's possible to keep the traditional functionality by setting this specific device option:
no_position_support: true
I've also fixed "invert_cover" support to be coherent with all the get / set functions

@Koenkk
Copy link
Owner

Koenkk commented Apr 17, 2021

@PxPert
Copy link
Contributor Author

PxPert commented Apr 17, 2021

Hi @Koenkk Sure.
Let's wait for feedback from @overclockato and then I'll update the docs

@overclockato
Copy link
Contributor

Hi @Koenkk , Hi @PxPert ,

the changes are okay for me too.

Thanks @Koenkk , thanks @PxPert, Regards.

@Koenkk
Copy link
Owner

Koenkk commented Apr 18, 2021

Thanks!

@Koenkk Koenkk merged commit 894e353 into Koenkk:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants