Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new model ID for Saswell TRVs #2594

Merged
merged 1 commit into from
May 18, 2021
Merged

Add new model ID for Saswell TRVs #2594

merged 1 commit into from
May 18, 2021

Conversation

drzony
Copy link
Contributor

@drzony drzony commented May 17, 2021

No description provided.

@hnykda
Copy link
Contributor

hnykda commented May 17, 2021 •
edited
Loading

Really appreciated, thanks, was just doing it by myself. (ref: Koenkk/zigbee2mqtt#3821 (comment))

@Koenkk
Copy link
Owner

Koenkk commented May 18, 2021

Thanks!

@Koenkk Koenkk merged commit 3e208f3 into Koenkk:master May 18, 2021
@hnykda
Copy link
Contributor

hnykda commented May 18, 2021

Hey. I tried that but unfortunately wasn't successful 😞 . Here is a log: https://gist.github.com/hnykda/65850a59b8a27d317eeb9fc1fdf5aeba. Should I open a new ticket for that?

@drzony
Copy link
Contributor Author

drzony commented May 18, 2021

I don't know what the release process is, so there is a possibility that the above change was not built yet.

@hnykda
Copy link
Contributor

hnykda commented May 19, 2021 •
edited
Loading

Well, according to https://github.com/Koenkk/zigbee-herdsman-converters/commits/master, there has been 14.0.150 release of this repo. In https://github.com/Koenkk/zigbee2mqtt/commits/dev, I can see updating to this version: Koenkk/zigbee2mqtt@7bdf52d . But even though I am on the commit 7bdf52, it doesn't work and still shows as unsupported.

I will try to read the device again.

@drzony
Copy link
Contributor Author

drzony commented May 19, 2021

In your log I've seen commit #45aa352, so this means that your version did not contain the fix

@drzony drzony deleted the saswell-new-model-id branch May 19, 2021 07:43
@hnykda
Copy link
Contributor

hnykda commented May 19, 2021

Sorry for confusion - I have tried again with 7bdf52d and that's what I was referring to:

info  2021-05-19 09:25:49: Logging to console and directory: '/config/zigbee2mqtt/log/2021-05-19.09-25-42' filename: log.txt
info  2021-05-19 09:25:49: Starting Zigbee2MQTT version 1.18.3-dev (commit #7bdf52d)
info  2021-05-19 09:25:49: Starting zigbee-herdsman (0.13.102)
info  2021-05-19 09:25:53: zigbee-herdsman started
info  2021-05-19 09:25:53: Coordinator firmware version: '{"meta":{"maintrel":3,"majorrel":2,"minorrel":6,"product":0,"revision":20201127,"transportrev":2},"type":"zStack12"}'
info  2021-05-19 09:25:53: Currently 10 devices are joined:
info  2021-05-19 09:25:53: TestZarovka1 (0x00158d0005726289): ZNLDP12LM - Xiaomi Aqara smart LED bulb (Router)
info  2021-05-19 09:25:53: SenzorVlhkostiATeploty (0x00158d00068b6b01): WSDCGQ11LM - Xiaomi Aqara temperature, humidity and pressure sensor (EndDevice)
info  2021-05-19 09:25:53: PohybovySenzor (0x00158d0006ba9490): RTCGQ11LM - Xiaomi Aqara human body movement and illuminance sensor (EndDevice)
info  2021-05-19 09:25:53: AqaraCube (0x00158d0005cf3268): MFKZQ01LM - Xiaomi Mi/Aqara smart home cube (EndDevice)
info  2021-05-19 09:25:53: DoubleSwitch (0x00158d0006515e80): WXKG07LM - Xiaomi Aqara D1 double key wireless wall switch (EndDevice)
info  2021-05-19 09:25:53: TripleSwitch (0x04cf8cdf3c7d8f7a): WXCJKG13LM - Xiaomi Aqara Opple switch 3 bands (EndDevice)
info  2021-05-19 09:25:53: HlaviceElza (0xbc33acfffe05907f): TS0601_thermostat - TuYa Radiator valve with thermostat (EndDevice)
info  2021-05-19 09:25:53: GledoptoGeorge (0x00124b0022612a0d): GL-C-008-2ID - Gledopto Zigbee LED Controller RGB+CCT (2 ID) (Router)
info  2021-05-19 09:25:53: TRVLivingRoom (0x804b50fffe4466e0): SEA801-Zigbee/SEA802-Zigbee - Saswell Thermostatic radiator valve (EndDevice)
info  2021-05-19 09:25:53: 0x804b50fffe446a4c (0x804b50fffe446a4c): Not supported (EndDevice)
info  2021-05-19 09:25:53: Zigbee: disabling joining new devices.
info  2021-05-19 09:25:53: Started frontend on port 0.0.0.0:8099
error 2021-05-19 09:25:53: Not connected to MQTT server!
error 2021-05-19 09:25:53: Cannot send message: topic: 'zigbee2mqtt/bridge/event', payload: '{"data":{"friendly_name":"0x804b50fffe446a4c","ieee_address":"0x804b50fffe446a4c"},"type":"device_announce"}
error 2021-05-19 09:25:53: Not connected to MQTT server!
error 2021-05-19 09:25:53: Cannot send message: topic: 'zigbee2mqtt/bridge/log', payload: '{"message":"announce","meta":{"friendly_name":"0x804b50fffe446a4c"},"type":"device_announced"}
info  2021-05-19 09:25:53: Connecting to MQTT server at mqtt://core-mosquitto:1883
warn  2021-05-19 09:25:54: Received message from unsupported device with Zigbee model 'TS0601' and manufacturer name '_TZE200_zuhszj9s'
warn  2021-05-19 09:25:54: Please see: https://www.zigbee2mqtt.io/how_tos/how_to_support_new_devices.html.
info  2021-05-19 09:25:55: Connected to MQTT server

@drzony
Copy link
Contributor Author

drzony commented May 19, 2021

Have you tried re-pairing the TRVs?

@hnykda
Copy link
Contributor

hnykda commented May 19, 2021

Not yet, will do as I wrote in #2594 (comment) (physically not on site atm). Will get back in a few hours how it went

@hnykda
Copy link
Contributor

hnykda commented May 19, 2021 •
edited
Loading

So I tried the mentioned commit (log).

  1. I removed the device
  2. it pairs fine, but throws an error about not being supported

Is there anything more I can provide you with?

@hnykda
Copy link
Contributor

hnykda commented May 19, 2021

image

hnykda
hnykda reviewed May 19, 2021
View reviewed changes
devices/saswell.js
@@ -15,6 +15,7 @@ module.exports = [
{modelID: 'TS0601', manufacturerName: '_TZE200_c88teujp'},
{modelID: 'TS0601', manufacturerName: '_TZE200_yw7cahqs'},
{modelId: 'TS0601', manufacturerName: '_TZE200_azqp6ssj'},
{modelID: 'TS0601', manufacturerName: '_TYST11_zuhszj9s'},
Copy link
Contributor

@hnykda hnykda May 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drzony Isn't this just caused by a typo in the end 😯 ? In my log, I see _TZE200_zuhszj9s, not _TYST11_zuhszj9s.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried here maybe? #2601

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the problem. Copy-Paste error on my side

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, really appreciate the help and the pointers 👍

@hnykda hnykda mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnykda hnykda hnykda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drzony @hnykda @Koenkk