Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR Home TS0204 Gas Sensor Remove battery #3820

Merged
merged 3 commits into from
Mar 5, 2022

Conversation

robertalexa
Copy link
Contributor

Just removing the battery related exposes.

Battery_low in my case reports False
Battery reports Null

The device gets powered via mains, no internal battery advertised by the sellers, idk why this exposed battery.

Looking at previous PRs i couldn't find anything for this device. Looking at git log, the code shows up first time when the code base was split by device file, but i can't find any history older than that, although I have not done serious digging into the original file.

When you unplug the device from the mains, the device powers off, sign of no internal battery.

Also the device shows as mains powered in z2m - DC Source
image

@Koenkk
Copy link
Owner

Koenkk commented Feb 5, 2022

@robertalexa is your device labeled as CR Smart home? Otherwise I also propose to move this device to tuya.js en change the vendor to tuya

@robertalexa
Copy link
Contributor Author

@Koenkk Not sure to be honest. It appears the CR Smart Home website is now dead, so I have no reference of what the original product looks like? http://crsmarthome.nl/

My device looks identical to the image on z2m.io Here is the link to the device listing
https://www.aliexpress.com/item/1005001692323775.html

image

Not sure what to say about the best approach?

@robertalexa
Copy link
Contributor Author

robertalexa commented Feb 5, 2022

I was just trying to provide the device from database file and weirdly, the file is not available in Studio Code?
image

But i can find it inside the container:
image

Did anything change recently? Is this expected behaviour?

@Koenkk
Copy link
Owner

Koenkk commented Feb 6, 2022

CR smart home looks dead indeed, might be better to move everything to tuya.js.

Not sure why vscode doens't show if, if your file browser shows it vscode should also show it, nothing has been changed there.

@robertalexa
Copy link
Contributor Author

I can try to have a look and move it to tuya one of these days. Leave my PR open for now.

As with VS code, turns out is has a File Exclude **/*.db hence.... yeah... All good, PEBKAC

@robertalexa robertalexa marked this pull request as draft February 6, 2022 13:45
@robertalexa robertalexa marked this pull request as ready for review March 4, 2022 13:08
@robertalexa
Copy link
Contributor Author

Hi @Koenkk

Apologies for the delay, had some personal situations and didn't get a chance to work on this.

I can see that as of last release you have already migrated all CR Home devices to Tuya as a result of someone else doing a PR on z2m.io Koenkk/zigbee2mqtt.io#1252

As a result, I have brought this branch back in line with master, and replicated the work in the tuya.js file instead of the original CR.

Thanks

@Koenkk
Copy link
Owner

Koenkk commented Mar 5, 2022

Apologies for the delay, had some personal situations and didn't get a chance to work on this.

No problem! Hope everything is well, thanks as always!

@Koenkk Koenkk merged commit 2a0a919 into Koenkk:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants