Fix duplication temperature/device_temperature SSM-U01 #4267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSM-U01 now is publishing two sensors (
temperature
anddevice_temperature
) that get the data from the same "physical" sensor. So it has a duplication in the sensors published.The SSM-U01 does not publish the
temperature
(clustermsTemperatureMeasurement
), in place it publishes thedevice_temperature
(clustergenDeviceTempCfg
). It publishes the same value too in theaqaraOpple
cluster, attribute3
.This PR removes the
temperature
converter from the device, letting only thedevice_temperature
one, and modifies theaqara_opple
converter to publish the value asdevice_temperature
in place oftemperature
.I'm pretty sure some people will complain about this, because the
device_temperature
has no options to "calibrate" it. But we need to unify both sensors, in one sense or in the other.